Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Component Governance to build #6088

Merged
merged 1 commit into from Feb 3, 2022
Merged

Add Component Governance to build #6088

merged 1 commit into from Feb 3, 2022

Conversation

mrivera-ms
Copy link
Contributor

@mrivera-ms mrivera-ms commented Jan 4, 2022

The injected Component Governance task does not enable the option to fail the build when alerts are raised. This change adds the step to our build with the option to fail builds in case of alerts.

#minor

@mrivera-ms mrivera-ms requested a review from a team as a code owner January 4, 2022 02:10
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 284570

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 8 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.03%) to 78.669%

Files with Coverage Reduction New Missed Lines %
/libraries/AdaptiveExpressions/BuiltinFunctions/GetPreviousViableTime.cs 1 93.94%
/libraries/Microsoft.Bot.Connector.Streaming/Session/StreamingSession.cs 3 89.62%
/libraries/AdaptiveExpressions/LRUCache.cs 4 82.05%
Totals Coverage Status
Change from base Build 284534: -0.03%
Covered Lines: 24872
Relevant Lines: 31616

💛 - Coveralls

@gabog
Copy link
Contributor

gabog commented Feb 3, 2022

Should we merge this one @mrivera-ms? or we are still waiting for additional feedback?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants