Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API compatibility validation improvements, DotNet #6481

Merged
merged 9 commits into from
Oct 4, 2022

Conversation

BruceHaley
Copy link
Contributor

@BruceHaley BruceHaley commented Sep 27, 2022

Fixes #minor

Description

Task 'Verify publish compat results success' is now redundant. It compensated for a bug in the 'Publish compat results to GitHub' task which has been fixed.

Fix API validation to download all packages for both the contract and the implementation: Presence of the dependent packages for both gets more accurate validating. (For example, the assembly:TypeForwardedTo statement is then supported.)

Specific Changes

  • Remove task 'Verify publish compat results success'.
  • Fix download to get all packages for API compare. (Readme does not explain how interdependent assembly handling affects ApiCompat reporting accuracy dotnet/arcade#9725).
  • Add task 'Publish compat results to Artifacts'. This makes results more accessible to forks, as they are not published to forked PRs.
  • Add file ApiCompatBaseline.txt. This replaces the functionality of the var ApiCompatExcludeClasses, with the added benefit of allowing API validation to succeed (go green) instead of always showing partial success.
  • Tweak var names and display names for readability.

@coveralls
Copy link
Collaborator

coveralls commented Sep 27, 2022

Pull Request Test Coverage Report for Build 324149

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 13 unchanged lines in 5 files lost coverage.
  • Overall coverage decreased (-0.04%) to 79.073%

Files with Coverage Reduction New Missed Lines %
/libraries/AdaptiveExpressions/BuiltinFunctions/GetNextViableTime.cs 1 90.91%
/libraries/AdaptiveExpressions/BuiltinFunctions/GetPreviousViableTime.cs 1 90.91%
/libraries/Microsoft.Bot.Connector.Streaming/TaskExtensions.cs 1 82.61%
/libraries/Microsoft.Bot.Connector.Streaming/Transport/TransportHandler.cs 2 96.39%
/libraries/Microsoft.Bot.Connector.Streaming/Session/StreamingSession.cs 8 89.62%
Totals Coverage Status
Change from base Build 324121: -0.04%
Covered Lines: 25580
Relevant Lines: 32350

💛 - Coveralls

@BruceHaley BruceHaley marked this pull request as ready for review September 27, 2022 19:16
@BruceHaley BruceHaley requested a review from a team as a code owner September 27, 2022 19:16
@BruceHaley BruceHaley marked this pull request as draft September 27, 2022 19:16
@BruceHaley BruceHaley added Area: Engineering Internal issues that are related to improving code quality, refactorings, code cleanup, etc. Automation: No parity PR does not need to be applied to other languages. labels Oct 3, 2022
@BruceHaley BruceHaley changed the title Clean up API compat publishing in CI-PR pipeline Update API compatibility validation in CI-PR pipeline Oct 4, 2022
@BruceHaley BruceHaley changed the title Update API compatibility validation in CI-PR pipeline API compatibility validation improvements, DotNet Oct 4, 2022
@BruceHaley BruceHaley marked this pull request as ready for review October 4, 2022 18:00
@BruceHaley BruceHaley merged commit 2c2aadf into main Oct 4, 2022
@BruceHaley BruceHaley deleted the bruce/dropverify9-27 branch October 4, 2022 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Engineering Internal issues that are related to improving code quality, refactorings, code cleanup, etc. Automation: No parity PR does not need to be applied to other languages.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants