-
Notifications
You must be signed in to change notification settings - Fork 478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API compatibility validation improvements, DotNet #6481
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 324149
💛 - Coveralls |
BruceHaley
added
Area: Engineering
Internal issues that are related to improving code quality, refactorings, code cleanup, etc.
Automation: No parity
PR does not need to be applied to other languages.
labels
Oct 3, 2022
BruceHaley
changed the title
Clean up API compat publishing in CI-PR pipeline
Update API compatibility validation in CI-PR pipeline
Oct 4, 2022
BruceHaley
changed the title
Update API compatibility validation in CI-PR pipeline
API compatibility validation improvements, DotNet
Oct 4, 2022
tracyboehrer
approved these changes
Oct 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Area: Engineering
Internal issues that are related to improving code quality, refactorings, code cleanup, etc.
Automation: No parity
PR does not need to be applied to other languages.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #minor
Description
Task 'Verify publish compat results success' is now redundant. It compensated for a bug in the 'Publish compat results to GitHub' task which has been fixed.
Fix API validation to download all packages for both the contract and the implementation: Presence of the dependent packages for both gets more accurate validating. (For example, the assembly:TypeForwardedTo statement is then supported.)
Specific Changes