[#6741] Update projects to .Net 8 #6760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ceciliaavila
added
the
Automation: No parity
Pull Request Test Coverage Report for Build 389178Details
💛 - Coveralls |
|
@ceciliaavila If it doesn't cause any issues, lets retain the 3.1 support in the packages. |
Sure, we'll update the projects to keep supporting netcoreapp 3.1. |
|
@ceciliaavila @sw-joelmut Were the changes to retain 3.1 support (if possible) made? |
|
Hi @tracy, we prioritized other issues over this, but we can address it next week. |
|
[like] Tracy Boehrer reacted to your message:
…________________________________
From: Joel Mut ***@***.***>
Sent: Friday, April 19, 2024 1:40:41 PM
To: microsoft/botbuilder-dotnet ***@***.***>
Cc: Tracy Boehrer ***@***.***>; Review requested ***@***.***>
Subject: Re: [microsoft/botbuilder-dotnet] [#6741] Update projects to .Net 8 (PR #6760)
Hi @tracy<https://github.com/tracy>, we prioritized other issues over this, but we can address it next week.
—
Reply to this email directly, view it on GitHub<#6760 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAH2HBV72KPUATVSI36I2N3Y6ENFTAVCNFSM6AAAAABEQNLLY2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANRWGYYTKMJTGI>.
You are receiving this because your review was requested.Message ID: ***@***.***>
|
|
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Integration.AspNet.Core.dll |
|
Hi @tracyboehrer, the changes to maintain support for Net Core 3.1 are ready in the PR. |
tracyboehrer
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #6741
#minor
Description
This PR updates the test projects, the test bots, and the CI pipelines to target .NET 8.
All these changes need to be done in one PR for the build checks to pass.
We divided the changes into three commits to ease the review:
Note: The FunctionalTests pipelines and the generators will be updated in separate PRs.
Specific Changes
For the test projects:
For the bots projects:
For the CI pipelines yamls:
Testing
This image shows the TestBot bots working as expected after the update.
Here we can see the CI pipeline working after the changes.
