This repository has been archived by the owner on Dec 4, 2023. It is now read-only.
Dialog.run refactor #1059
Merged
Dialog.run refactor #1059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Going to wait on this until .NET is completed. |
|
Some of the fixes I made during this may be good to have at this time as they correct some skills issues that this update uncovered. I think we should go ahead and push this and we can add any additional changes later that John may make that are related and do those in another PR. |
tracyboehrer
approved these changes
Mar 16, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1046
Description
Refactored code as outlined in Issue #1046 to remove redundant code in Dialog and DialogManager.
Specific Changes
Following the C# coding example applied the same refactoring logic to remove redundant code from DialogManager and Dialog and replace it with a shared code implementation in Dialog.
Testing
All unit tests were run and all issue found were remediated as part of this effort.