Skip to content
This repository has been archived by the owner on Dec 4, 2023. It is now read-only.

[SDK][Bot-Azure] Add BlobsStorage component #1066

Conversation

fran893
Copy link
Contributor

@fran893 fran893 commented Mar 19, 2021

Fixes #908

Description

Implements BlobsStorage class and its unit tests. This PR also fixes a few disparities with C# present in different classes. Also, it's improving the parity C# - Java adding last changes of the repository.

Specific Changes

Testing

BlobsStorageTests unit tests correctly passing
image

TranscriptStoreTests unit tests correctly passing
image

mvn clean install of the entire solution
image

@Batta32
Copy link
Contributor

Batta32 commented Mar 19, 2021

Hi @tracyboehrer, the unit test for this implementation requires Azure Storage Emulator, just like the PR #1033.

* Apply Tracy feedback

* Rename afterTest to testCleanup
@Batta32
Copy link
Contributor

Batta32 commented Mar 22, 2021

@tracyboehrer, we replaced the assertEmulator with runIfEmulator as requested 😊.

@Batta32
Copy link
Contributor

Batta32 commented Mar 23, 2021

@tracyboehrer, we updated this branch too and the build passed!

@tracyboehrer tracyboehrer merged commit 5c00a74 into microsoft:main Mar 23, 2021
@Batta32 Batta32 deleted the external/feature/southworks/blobstorage/base branch March 23, 2021 20:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bot-azure, AzureBlobStorage
4 participants