This repository has been archived by the owner on Dec 4, 2023. It is now read-only.
Activity#clone did not consider fields textFormat, attachmentLayout, topicName, listenFor #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…topicName, listenFor
matthiasblaesing
force-pushed
the
fullclone-activity
branch
from
c5fbdf0
to
717d227
Compare
tracyboehrer
approved these changes
Oct 30, 2019
There was a problem hiding this comment.
@matthiasblaesing Thank you for taking the time to do this.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tested the MemoryTranscriptStore and noticed, that the activities were missing
the textFormat property, that worked correctly when send to the bot. This PR
adds the fields, that are not yet cloned.