Skip to content
This repository has been archived by the owner on Dec 4, 2023. It is now read-only.

Remove the unnecessary filtering, the bot itself has been filtered out already in ActivityHandler.java #453

Merged

Conversation

fredrikluo
Copy link
Contributor

The bot itself has been filtered in activityHandler.java see:

.anyMatch(m -> !StringUtils.equals(m.getId(), activity.getRecipient().getId()))

Suggest removing this line from the sample since it's quite confusing, it could lead people to think onMembersAdded will be called when the bot is added to the channel, which is reasonable since bot service does send out MemebersAdd when a bot is added.

This, of course, will never happen.

@tracyboehrer
Copy link
Member

@fredrikluo Thanks! I'll look into the build issue. I don't believe it's related to your PR.

@tracyboehrer tracyboehrer merged commit f42fc99 into microsoft:master Apr 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants