Replace Map with WeakMap to avoid memory leak (#4517)

microsoft · Aug 8, 2023 · 5b58d10 · 5b58d10
1 parent 85a22f3
commit 5b58d10
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/libraries/adaptive-expressions/src/parser/expressionParser.ts b/libraries/adaptive-expressions/src/parser/expressionParser.ts
@@ -27,7 +27,7 @@ export class ExpressionParser implements ExpressionParserInterface {
      */
     readonly EvaluatorLookup: EvaluatorLookup;
 
-    private static expressionDict: Map<string, ParseTree> = new Map<string, ParseTree>();
+    private static expressionDict: WeakMap<any, ParseTree> = new WeakMap<any, ParseTree>();
 
     private readonly ExpressionTransformer = class
         extends AbstractParseTreeVisitor<Expression>
@@ -279,8 +279,8 @@ export class ExpressionParser implements ExpressionParserInterface {
      * @returns A ParseTree.
      */
     protected static antlrParse(expression: string): ParseTree {
-        if (ExpressionParser.expressionDict.has(expression)) {
-            return ExpressionParser.expressionDict.get(expression);
+        if (ExpressionParser.expressionDict.has({ key: expression })) {
+            return ExpressionParser.expressionDict.get({ key: expression });
         }
 
         const inputStream: ANTLRInputStream = new ANTLRInputStream(expression);
@@ -297,7 +297,7 @@ export class ExpressionParser implements ExpressionParserInterface {
         if (file !== undefined) {
             expressionContext = file.expression();
         }
-        ExpressionParser.expressionDict.set(expression, expressionContext);
+        ExpressionParser.expressionDict.set({ key: expression }, expressionContext);
 
         return expressionContext;
     }

diff --git a/libraries/botbuilder-dialogs-adaptive/src/languageGeneratorExtensions.ts b/libraries/botbuilder-dialogs-adaptive/src/languageGeneratorExtensions.ts
@@ -36,7 +36,7 @@ export const languagePolicyKey = Symbol('LanguagePolicy');
  * Extension methods for language generator.
  */
 export class LanguageGeneratorExtensions {
-    private static readonly _languageGeneratorManagers = new Map<ResourceExplorer, LanguageGeneratorManager>();
+    private static readonly _languageGeneratorManagers = new WeakMap<ResourceExplorer, LanguageGeneratorManager>();
 
     /**
      * Register default LG file or a language generator as default language generator.