Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSP Issue caused by botframework-streaming library #2647

Closed
rajdhandus opened this issue Aug 5, 2020 · 1 comment · Fixed by #2752
Closed

CSP Issue caused by botframework-streaming library #2647

rajdhandus opened this issue Aug 5, 2020 · 1 comment · Fixed by #2752
Assignees
@stevengum
Labels
Area: Streaming Issues related to streaming support needs-triage The issue has just been created and it has not been reviewed by the team.

Comments

@rajdhandus
Copy link

rajdhandus commented Aug 5, 2020 •
edited by Zerryth
Loading

Versions

What package version of the SDK are you using.
botframework-streaming 4.9.2

Describe the bug

Give a clear and concise description of what the bug is.
CSP error noticed in the client side browser because of new Function() code in doesGlobalFileReaderExist.ts

https://developers.google.com/web/fundamentals/security/csp/#eval_too
@v-aabro v-aabro mentioned this issue Aug 10, 2020
Closed
@compulim
Copy link
Contributor

Assigning to @stevengum as he own botframework-streaming.

This was referenced Aug 28, 2020
Merged
Merged
@gabog gabog added Area: Streaming Issues related to streaming support needs-triage The issue has just been created and it has not been reviewed by the team. and removed Streaming Extensions labels Sep 2, 2020
@stevengum stevengum mentioned this issue Sep 4, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stevengum stevengum

Labels
Area: Streaming Issues related to streaming support needs-triage The issue has just been created and it has not been reviewed by the team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

address unsafe-eval CSP issues, additional cleanup microsoft/botbuilder-js
5 participants
@compulim @rajdhandus @gabog @stevengum @Zerryth