Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

port: Add AllowedSkillsClaimsValidator for Issue 5285 (#5684) #3814

Closed
github-actions bot opened this issue Jun 25, 2021 · 0 comments · Fixed by #3816
Closed

port: Add AllowedSkillsClaimsValidator for Issue 5285 (#5684) #3814

github-actions bot opened this issue Jun 25, 2021 · 0 comments · Fixed by #3816
Assignees
Labels
Area: Runtime Work related to the core runtime Area: Skills The issue is related to skills parity The issue describes a gap in parity between two or more platforms.

Comments

@github-actions
Copy link

The changes in Add AllowedSkillsClaimsValidator for Issue 5285 (#5684) may need to be ported to maintain parity with microsoft/botbuilder-dotnet.

Fixes #5285

Description

Added AllowedSkillsClaimsValidator as needed to support skills in the AdaptiveRuntime so that allowedCallers are inferred correctly and validated from the configured skills.

Specific Changes

Added AllowedSkillsClaimsValidator and add it as a singleton as an AuthenticationConfiguration in AddBotRunTimeSkills in ServiceCollectionExtensions.cs.

Because AllowedSkillsClaimsValidator originally was part of the samples/test code and not part of the SDK this meant that there was now an ambiguous reference which had to be handled in the test code, and will need to be updated in the samples as well. It is possible to update the samples/test code to no longer have their own copies of the AllowedSkillsClaimsValidator and have them use the SDK version by having them instantiate the SDK version and pass in a list of allowed callers which could be extracted from the current SkillsConfiguration class that they use (also defined locally to the sample/test). It seems when the AllowedCallersClaimsValidator was added to the SDK that the samples/tests were just updated to use the new SDK class, is that what we want to do here as well?

Testing

Tested with bot projects created from Composer that were configured to use the modified SDK code.

Please review and, if necessary, port the changes.

@github-actions github-actions bot added ExemptFromDailyDRIReport Use this label to exclude the issue from the DRI report. needs-triage The issue has just been created and it has not been reviewed by the team. parity The issue describes a gap in parity between two or more platforms. labels Jun 25, 2021
@joshgummersall joshgummersall self-assigned this Jun 25, 2021
@joshgummersall joshgummersall added Area: Skills The issue is related to skills Area: Runtime Work related to the core runtime and removed ExemptFromDailyDRIReport Use this label to exclude the issue from the DRI report. needs-triage The issue has just been created and it has not been reviewed by the team. labels Jun 25, 2021
joshgummersall pushed a commit that referenced this issue Jun 25, 2021
stevengum pushed a commit that referenced this issue Jun 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Runtime Work related to the core runtime Area: Skills The issue is related to skills parity The issue describes a gap in parity between two or more platforms.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant