Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CloudAdapter don't work with Teams SSO #4408

Closed
aregnet opened this issue Jan 13, 2023 · 4 comments · Fixed by #4427
Closed

CloudAdapter don't work with Teams SSO #4408

aregnet opened this issue Jan 13, 2023 · 4 comments · Fixed by #4427
Assignees
Labels
Bot Services Required for internal Azure reporting. Do not delete. Do not change color. bug Indicates an unexpected problem or an unintended behavior. customer-reported Issue is created by anyone that is not a collaborator in the repository.

Comments

@aregnet
Copy link

aregnet commented Jan 13, 2023

Versions

What package version of the SDK are you using. 4.19.0
What nodejs version are you using: 16.19.0
What browser version are you using: Teams Windows Client
What os are you using. Windows 10

Describe the bug

Teams SSO doesn't work with the CloudAdapter class. I spent a lot of time with debugging and checking my configuration.
I followed the instructions at this repo: https://github.com/OfficeDev/Microsoft-Teams-Samples/tree/main/samples/bot-conversation-sso-quickstart/js

After sending the OAuthPromt Dialog, I get an error message "ExtendedUserTokenProvider".
If I use the deprecated BotFrameworkAdapter everything works as expected.

This happens because the CloudAdapter doesn't implement the "exchangeToken" method (i guess).
So I'm not sure whether the samples or the lib is not as expected.

To Reproduce

Use the code and instructions from: https://github.com/OfficeDev/Microsoft-Teams-Samples/tree/main/samples/bot-conversation-sso-quickstart/js

Expected behavior

Teams SSO with the CloudAdapter class.

@aregnet aregnet added bug Indicates an unexpected problem or an unintended behavior. needs-triage The issue has just been created and it has not been reviewed by the team. labels Jan 13, 2023
@jaytees
Copy link

jaytees commented Jan 25, 2023

interested in the answer to this issue as well

@erquirogasw
Copy link
Contributor

Hi @johnataylor. We were able to reproduce this issue using the bot-conversation-sso-quickstart sample.
If there's no problem, we could continue reviewing it.

@InfinytRam
Copy link
Contributor

Thanks @erquirogasw.

Can I assign this issue to you?

@InfinytRam InfinytRam added Bot Services Required for internal Azure reporting. Do not delete. Do not change color. customer-reported Issue is created by anyone that is not a collaborator in the repository. and removed needs-triage The issue has just been created and it has not been reviewed by the team. labels Feb 3, 2023
@erquirogasw
Copy link
Contributor

@ramfattah sure. We already have the fix and we are finishing adding new unit tests.

johnataylor pushed a commit that referenced this issue Feb 8, 2023
* Updated teamsSSOTokenExchangeMiddleware.ts

* Updated wrong provided token message

* Code improvements

* Suggested changes applied

* Added unit tests.

---------

Co-authored-by: Emiliano Quiroga <emiliano.quiroga@7-11.com>
tracyboehrer pushed a commit that referenced this issue Feb 28, 2023
* Updated teamsSSOTokenExchangeMiddleware.ts

* Updated wrong provided token message

* Code improvements

* Suggested changes applied

* Added unit tests.

---------

Co-authored-by: Emiliano Quiroga <emiliano.quiroga@7-11.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bot Services Required for internal Azure reporting. Do not delete. Do not change color. bug Indicates an unexpected problem or an unintended behavior. customer-reported Issue is created by anyone that is not a collaborator in the repository.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants