Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

port: [#6563] Expired JWT token exception not being handled (#6572) #4432

Closed
ceciliaavila opened this issue Feb 13, 2023 · 0 comments · Fixed by #4436
Closed

port: [#6563] Expired JWT token exception not being handled (#6572) #4432

ceciliaavila opened this issue Feb 13, 2023 · 0 comments · Fixed by #4436
Assignees
@ceciliaavila
Labels
ExemptFromDailyDRIReport Use this label to exclude the issue from the DRI report. needs-triage The issue has just been created and it has not been reviewed by the team. parity The issue describes a gap in parity between two or more platforms.

Comments

@ceciliaavila
Copy link
Collaborator

The changes in [#6563] Expired JWT token exception not being handled (#6572) may need to be ported to maintain parity with microsoft/botbuilder-dotnet.

Fixes #6563

Description

This PR catches the SecurityTokenExpiredException when a JWT token is expired.

Specific Changes

  • Added catch block on the ValidateTokenAsync method of the JwtTokenExtractor class.
  • Added unit test for the JwtTokenExtractor class.
  • Added unit test for the CloudAdapter class.

Testing

These images show the new unit tests passing.
image

Please review and, if necessary, port the changes.
@ceciliaavila ceciliaavila added ExemptFromDailyDRIReport Use this label to exclude the issue from the DRI report. needs-triage The issue has just been created and it has not been reviewed by the team. parity The issue describes a gap in parity between two or more platforms. labels Feb 13, 2023
@ceciliaavila ceciliaavila self-assigned this Feb 13, 2023
@ceciliaavila ceciliaavila mentioned this issue Feb 17, 2023
Merged
tracyboehrer pushed a commit that referenced this issue May 5, 2023
@ceciliaavila
port: [#4432] Expired JWT token exception not being handled (#6572) (#…
3fe6730 
…4436)

* Add expired token exception and tests

* Fix depcheck issues

* Fix failing test.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ceciliaavila ceciliaavila

Labels
ExemptFromDailyDRIReport Use this label to exclude the issue from the DRI report. needs-triage The issue has just been created and it has not been reviewed by the team. parity The issue describes a gap in parity between two or more platforms.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

port: [#4432] Expired JWT token exception not being handled (#6572) microsoft/botbuilder-js
1 participant
@ceciliaavila