add actionBasedMessagingExtension from samples repo, update .gitignore #1225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 80964
💛 - Coveralls |
tsuwandy
approved these changes
Sep 27, 2019
| import { BotFrameworkAdapter } from 'botbuilder'; | ||
|
|
||
| // This bot's main dialog. | ||
| import { TeamsActionExtensionBot } from './teamsActionExtensionBot'; |
There was a problem hiding this comment.
Bot is called ActionBasedMessagingExtensionBot on C# side, shall we keep them consistent naming wise? Perhaps renamed the C# one?
There was a problem hiding this comment.
I'll rename this one to ActionBasedMessagingBot, to keep it consistent with the already checked-in scenario in C#. I'm going to add *.zip files to the .gitignore in this PR so we don't check in any zipped up manifests with credentials
stevengum
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1225
Description
Adding
messaging-extension-action/intobotbuilder/tests/teams.(Note this is not the final form, as the TeamsActivityHandler and ActivityHandler classes are updating, see #1223)