Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Teams] ComposeMessageExtensionAuthBot teams scenario #1250

Merged
merged 6 commits into from
Oct 4, 2019

Conversation

EricDahlvang
Copy link
Member

Fixes: #1239

@coveralls
Copy link

coveralls commented Oct 3, 2019

Pull Request Test Coverage Report for Build 81777

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 86.722%

Totals Coverage Status
Change from base Build 81771: 0.0%
Covered Lines: 4598
Relevant Lines: 5101

💛 - Coveralls

Copy link
Member

@stevengum stevengum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address Tien's feedback before merging this.

@stevengum stevengum dismissed tsuwandy’s stale review October 4, 2019 17:43

Addressing tsuwandy's feedback is required before this PR is merged.

@tsuwandy tsuwandy self-requested a review October 4, 2019 20:18
Copy link
Contributor

@tsuwandy tsuwandy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Eric!!

@tsuwandy tsuwandy self-requested a review October 4, 2019 20:21
Copy link
Contributor

@tsuwandy tsuwandy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Eric!!

@EricDahlvang EricDahlvang dismissed stevengum’s stale review October 4, 2019 20:50

Dismissing ... Tien has approved

@stevengum stevengum merged commit 9a2bdab into master Oct 4, 2019
@stevengum stevengum deleted the eric/addComposeMessageExtensionAuthBot branch October 4, 2019 21:57
}]
}
}
};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got into the practice of casting (so you get some sense of what each block is) - for example:
public static toComposeExtensionResultResponse(cardAttachment: Attachment) : MessagingExtensionActionResponse {

    return <MessagingExtensionActionResponse> {
        composeExtension: <MessagingExtensionResult> {
            type: 'result',
            attachmentLayout: 'list',
            attachments: [ <MessagingExtensionAttachment> cardAttachment ]

        }
    }
}

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That would be better ... i've just been casting the top level return, but should be casting the fields too, you're right!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.6 4.6 release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Port OAuth via messagingExtension from C# to JS
5 participants