-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding OAuthCard support for Streaming Extensions #1284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 82770
💛 - Coveralls |
carlosscastro
approved these changes
Oct 10, 2019
This is a port from a c# PR that we iterated a lot on. Looks good feature wise. Might be good to have some of the folks that regularly work on js to do a pass. |
Please merge when ready. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds OAuthCard resolution to connections made with streaming extensions.
Specific Changes
Adds the polling mechanism to retrieve OAuth tokens when an OAuthCard is sent via streaming extensions. This was the approved design, so porting it to the JS bot builder.
Basically:
When an OAuthCard is sent on streaming connection, the BotAdapter begins to poll for that particular token until it is found. The service can override and terminate the polling if need be. Once the token is retrieved, it is sent back through the adapter.
Testing
Added new tests that match the C# implementation.