rankerType got from options in QnA constructor

[davidalcoba]

Fixes #1951

Description

rankerType option passed as option parameter in QnA constructor was ignored

Specific Changes

• rankerType got from options parameters in QnA constructor
• unit test 'should call qnamaker with rankerType questionOnly' updated

Testing

• no tests added, only above mentioned test has been updated

[msftclas]

All CLA requirements met.

[vipeketi]

The score value should be in range of 0 and 1
/**
* Confidence on a scale from 0.0 to 1.0 that the answer matches the users intent.
*/
score: number;

[davidalcoba]

Thanks @vipeketi for your comment.

Not sure if I understand you, do you refer to the unit test response json? If so, I have to accept that I couldn't test the real qna service after providing the rankerType option because I assume that the qna api keys are not published. So I opted to modify directly the mock.

If someone could provide the real answer from qna service for the updated unit test, I will adapt the mock.

[vipeketi]

It was not clear to me on why the test response was modified to empty list in test case, for this code change. It is clear to me now. Sent from Mail<https://go.microsoft.com/fwlink/?LinkId=550986> for Windows 10

…

________________________________ From: deivkk <notifications@github.com> Sent: Friday, March 27, 2020 2:54:57 PM To: microsoft/botbuilder-js <botbuilder-js@noreply.github.com> Cc: Vijaya Peketi <VIJAYA.PEKETI@microsoft.com>; Mention <mention@noreply.github.com> Subject: Re: [microsoft/botbuilder-js] rankerType got from options in QnA constructor (#1953) Thanks @vipeketi<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fvipeketi&data=02%7C01%7CVIJAYA.PEKETI%40microsoft.com%7C8108c54affd94d685cd308d7d230b7e3%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637208978994655913&sdata=GB9OigZbLomzpUm3bj2AsOa2ce9qKCyALYcYZRCRgPM%3D&reserved=0> for your comment. Not sure if I understand you, do you refer to the unit test response json? If so, I have to accept that I couldn't test the real qna service after providing the rankerType option because I assume that the qna api keys are not published. So I opted to modify directly the mock. If someone could provide the real answer from qna service for the updated unit test, I will adapt the mock. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmicrosoft%2Fbotbuilder-js%2Fpull%2F1953%23issuecomment-604900176&data=02%7C01%7CVIJAYA.PEKETI%40microsoft.com%7C8108c54affd94d685cd308d7d230b7e3%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637208978994665905&sdata=JvecpACKaC4yD701aDorUt1tBEjZCeSwUtDYSAVibFU%3D&reserved=0>, or unsubscribe<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAN4DXHJPW3NLOZZUE6F5PZ3RJRWGTANCNFSM4LUQ7W7A&data=02%7C01%7CVIJAYA.PEKETI%40microsoft.com%7C8108c54affd94d685cd308d7d230b7e3%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637208978994665905&sdata=Pzh5Evr6ojbvZuI8Hy%2FyTauhONqGb0VIZTIiX7UVsKI%3D&reserved=0>.

[vipeketi]

Rankertype is set now.

[vipeketi]

Approved

[davidalcoba]

This pull request can be automatically merged by project collaborators
Only those with write access to this repository can merge pull requests.

Who can do that?

[vipeketi]

Merged changes.