Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PORT] Update IMemory interface and tryEvaluate for expression #1967

Merged
merged 4 commits into from
Apr 1, 2020

Conversation

cosmicshuai
Copy link
Contributor

@cosmicshuai cosmicshuai commented Mar 31, 2020

fixes: #1966

Add an optional parameter options in tryEvaluate.

Inside options, we allows user to set a callback function which been called whenever there is a null found in memory path, except for those in boolean context.

@coveralls
Copy link

coveralls commented Mar 31, 2020

Pull Request Test Coverage Report for Build 116818

  • 90 of 96 (93.75%) changed or added relevant lines in 5 files are covered.
  • 9 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.05%) to 81.398%

Changes Missing Coverage Covered Lines Changed/Added Lines %
libraries/adaptive-expressions/src/expressionFunctions.ts 83 89 93.26%
Files with Coverage Reduction New Missed Lines %
libraries/botframework-streaming/src/webSocket/webSocketTransport.ts 2 80.65%
libraries/botframework-streaming/src/webSocket/webSocketServer.ts 7 66.67%
Totals Coverage Status
Change from base Build 116308: -0.05%
Covered Lines: 9327
Relevant Lines: 11033

💛 - Coveralls

@boydc2014 boydc2014 merged commit 6cf631c into master Apr 1, 2020
@boydc2014 boydc2014 deleted the shuwan/expr-eval-option branch April 1, 2020 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[PORT] Update IMemory interface and tryEvaluate for expression
3 participants