Allow creation of multiple Cosmos containers #1984
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1975
Description
doOnce
was preventingcosmosDbPartitionedStorage
users from using multiple containers and/or databases. This is becausedoOnce
acted oncosmosDbPartitionedStorage
as a whole, rather than individual db/container combinations.Specific Changes
doOnce
-awaited functions, keyed by db+containerTesting
Added two tests, which fail without this change and pass with it.
Considerations
Is this the right approach, or would it be better to store the container as a property in
cosmosDbPartitionedStorage
? My hunch is that there might be concurrency issues with the class property approach.