Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor expander #2012

Merged
merged 2 commits into from
Apr 13, 2020
Merged

refactor expander #2012

merged 2 commits into from
Apr 13, 2020

Conversation

feich-ms
Copy link
Contributor

@feich-ms feich-ms commented Apr 12, 2020

Fixes #3523 microsoft/botbuilder-dotnet#3523
Fixes #2014

Description

Refactor lg expander to support full functions of LG and fix several issues such as excape, double quotation. Also change the return type from string array to object array.

Specific Changes

  • Support all kinds of LG functions

  • Discard the 'builtin.' prefix

  • Fix escape issues, including double quotation, escape character

  • change return type from string array to object array

Testing

Corresponding test cases are added in lg.test.js

@coveralls
Copy link

coveralls commented Apr 12, 2020

Pull Request Test Coverage Report for Build 119434

  • 15 of 15 (100.0%) changed or added relevant lines in 1 file are covered.
  • 9 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.1%) to 67.127%

Files with Coverage Reduction New Missed Lines %
libraries/botframework-streaming/src/webSocket/webSocketTransport.ts 2 80.65%
libraries/botframework-streaming/src/webSocket/webSocketServer.ts 7 66.67%
Totals Coverage Status
Change from base Build 119067: 0.1%
Covered Lines: 10263
Relevant Lines: 14465

💛 - Coveralls

@feich-ms feich-ms merged commit 51a4389 into master Apr 13, 2020
@feich-ms feich-ms deleted the feich/refactorExpander branch April 13, 2020 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[PORT] refactor expander
3 participants