Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed AtPathResolver to deal with complex objects correctly #2046

Merged
merged 2 commits into from
Apr 21, 2020
Merged

Fixed AtPathResolver to deal with complex objects correctly #2046

merged 2 commits into from
Apr 21, 2020

Conversation

chon219
Copy link
Member

@chon219 chon219 commented Apr 16, 2020

Fixes #1770

Description

Fixed AtPathResolver to deal with complex objects correctly

Specific Changes

  • Adjusted transformPath method in AtPathResolver to resolve path correctly

Testing

Unit tests covered.

@chon219 chon219 requested a review from Stevenic April 16, 2020 07:19
@chon219 chon219 self-assigned this Apr 16, 2020
@coveralls
Copy link

coveralls commented Apr 16, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 122113

  • 15 of 15 (100.0%) changed or added relevant lines in 1 file are covered.
  • 9 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.06%) to 76.874%
Files with Coverage Reduction New Missed Lines %
libraries/botframework-streaming/src/webSocket/webSocketTransport.ts 2 80.65%
libraries/botframework-streaming/src/webSocket/webSocketServer.ts 7 66.67%
Totals Coverage Status
Change from base Build 122111: -0.06%
Covered Lines: 11769
Relevant Lines: 14572
💛 - Coveralls

Stevenic
Stevenic approved these changes Apr 21, 2020
View reviewed changes
Copy link
Contributor

@Stevenic Stevenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@Stevenic Stevenic merged commit 3b34dd7 into master Apr 21, 2020
@Stevenic Stevenic deleted the zim/atresolver-fix branch April 21, 2020 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Stevenic Stevenic Stevenic approved these changes

Assignees

@chon219 chon219

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[PORT] Fix @ resolver to deal with complex objects correctly
3 participants
@chon219 @coveralls @Stevenic