Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates for CallerId #2052

Merged
merged 11 commits into from
Apr 21, 2020
Merged

Updates for CallerId #2052

merged 11 commits into from
Apr 21, 2020

Conversation

stevengum
Copy link
Member

@stevengum stevengum commented Apr 16, 2020

Port of microsoft/botbuilder-dotnet#3753 to JS

Fixes: #2055

Description

Updated callerId assignment to be taken from claims after auth rather than from the activity.
Updated related tests.

Specific Changes

Testing

@coveralls
Copy link

coveralls commented Apr 16, 2020

Pull Request Test Coverage Report for Build 122165

  • 53 of 60 (88.33%) changed or added relevant lines in 9 files are covered.
  • 12 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.2%) to 77.241%

Changes Missing Coverage Covered Lines Changed/Added Lines %
libraries/botbuilder/src/botFrameworkAdapter.ts 16 17 94.12%
libraries/botbuilder-dialogs/src/dialogHelper.ts 25 31 80.65%
Files with Coverage Reduction New Missed Lines %
libraries/botframework-streaming/src/webSocket/webSocketTransport.ts 2 80.65%
libraries/botbuilder-dialogs/src/dialogHelper.ts 3 75.76%
libraries/botframework-streaming/src/webSocket/webSocketServer.ts 7 66.67%
Totals Coverage Status
Change from base Build 122150: 0.2%
Covered Lines: 11844
Relevant Lines: 14607

💛 - Coveralls

@stevengum stevengum merged commit eac28c8 into master Apr 21, 2020
@stevengum stevengum deleted the stgum/id branch April 21, 2020 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[PORT] Updates for CallerId
3 participants