Add OAuthUrl constants and ensure forwarded activities contain a recipient value #2067
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1816
Fixes #1997
Description
If the forwarded activity to the skill is missing a recipient, certain methods can throw ReferenceErrors (or in dotnet, NullReferenceExceptions) as
Activtiy.recipient
is expected (#1997 This PR fixes that and adds a test for this scenario.The OAuthUrl constants in dotnet were missing from the AuthenticationConstants and GovernmentAuthenticationConstants in botframework-connector. These values have been added in the PR.
Specific Changes
{}
) to all forwarded activities if the field is missingTesting
Added tests