Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ported test cases for adaptive dialogs #2100

Merged
merged 11 commits into from
Apr 27, 2020
Merged

Ported test cases for adaptive dialogs #2100

merged 11 commits into from
Apr 27, 2020

Conversation

chon219
Copy link
Member

@chon219 chon219 commented Apr 24, 2020

Description

Ported test cases for adaptive dialogs from botbuilder-dotnet
Fixed some bugs to make sure we can pass every tests.

Specific Changes

  • Registered LG generators and selectors to let resource explorer load them from .dialog files
  • Ported missing test cases for AdaptiveDialog
  • Ported missing test cases for Selectors (except MostSpecificSelector as we don't have it yet)
  • Ported MiscTests/SettingsStateTests

Testing

@chon219 chon219 self-assigned this Apr 24, 2020
@coveralls
Copy link

coveralls commented Apr 24, 2020

Pull Request Test Coverage Report for Build 125194

  • 17 of 17 (100.0%) changed or added relevant lines in 5 files are covered.
  • 9 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.5%) to 79.706%

Files with Coverage Reduction New Missed Lines %
libraries/botframework-streaming/src/webSocket/webSocketTransport.ts 2 80.65%
libraries/botframework-streaming/src/webSocket/webSocketServer.ts 7 66.67%
Totals Coverage Status
Change from base Build 125027: 0.5%
Covered Lines: 12301
Relevant Lines: 14726

💛 - Coveralls

Copy link
Contributor

@Stevenic Stevenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@Stevenic Stevenic merged commit 93c485c into master Apr 27, 2020
@Stevenic Stevenic deleted the zim/adaptive-tests branch April 27, 2020 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants