Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added LuisAdaptiveRecognizer #2149

Merged
merged 3 commits into from
May 1, 2020
Merged

Added LuisAdaptiveRecognizer #2149

merged 3 commits into from
May 1, 2020

Conversation

Stevenic
Copy link
Contributor

@Stevenic Stevenic commented May 1, 2020

Fixes #1637

Description

Added missing LuisAdaptiveRecognizer class

@coveralls
Copy link

coveralls commented May 1, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 127407

  • 7 of 21 (33.33%) changed or added relevant lines in 4 files are covered.
  • 9 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.2%) to 79.774%
Changes Missing Coverage Covered Lines Changed/Added Lines %
libraries/botbuilder-dialogs-adaptive/src/luis/luisAdaptiveRecognizer.ts 3 17 17.65%
Files with Coverage Reduction New Missed Lines %
libraries/botframework-streaming/src/webSocket/webSocketTransport.ts 2 80.65%
libraries/botframework-streaming/src/webSocket/webSocketServer.ts 7 66.67%
Totals Coverage Status
Change from base Build 127399: -0.2%
Covered Lines: 12417
Relevant Lines: 14850
💛 - Coveralls

stevengum
stevengum requested changes May 1, 2020
View reviewed changes
Copy link
Member

@stevengum stevengum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some issues here, can you reply to the comments?

libraries/botbuilder-dialogs-adaptive/src/luis/luisAdaptiveRecognizer.ts Show resolved Hide resolved
libraries/botbuilder-dialogs-adaptive/src/luis/luisAdaptiveRecognizer.ts Show resolved Hide resolved
libraries/botbuilder-dialogs-adaptive/src/luis/luisAdaptiveRecognizer.ts Outdated Show resolved Hide resolved
@stevengum stevengum merged commit e3a4c1d into master May 1, 2020
@stevengum stevengum deleted the stevenic/adaptive-luis-recognizer branch May 1, 2020 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevengum stevengum stevengum approved these changes

@chrimc62 chrimc62 Awaiting requested review from chrimc62

@tomlm tomlm Awaiting requested review from tomlm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[PORT] External Entities & Dynamic lists
3 participants
@Stevenic @coveralls @stevengum