Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stevenic/adaptive fixes #2160

Merged
merged 8 commits into from
May 2, 2020
Merged

Stevenic/adaptive fixes #2160

merged 8 commits into from
May 2, 2020

Conversation

Stevenic
Copy link
Contributor

@Stevenic Stevenic commented May 1, 2020

Description

  • Added missing LG converter.
  • Fixed a case conversion issues.
  • Worked around a serialization issue for cards coming from LG.

@Stevenic Stevenic requested review from chon219 and stevengum May 1, 2020 22:01
stevengum
stevengum approved these changes May 1, 2020
View reviewed changes
Copy link
Member

@stevengum stevengum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge conflict and one question

libraries/botbuilder-dialogs-adaptive/src/generators/languageGeneratorManager.ts Show resolved Hide resolved
@Stevenic Stevenic requested a review from benbrown as a code owner May 2, 2020 00:18
@coveralls
Copy link

coveralls commented May 2, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 127484

  • 13 of 13 (100.0%) changed or added relevant lines in 6 files are covered.
  • 9 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.06%) to 79.788%
Files with Coverage Reduction New Missed Lines %
libraries/botframework-streaming/src/webSocket/webSocketTransport.ts 2 80.65%
libraries/botframework-streaming/src/webSocket/webSocketServer.ts 7 66.67%
Totals Coverage Status
Change from base Build 127463: -0.06%
Covered Lines: 12424
Relevant Lines: 14856
💛 - Coveralls

@Stevenic Stevenic merged commit 9cf7c2a into master May 2, 2020
@Stevenic Stevenic deleted the stevenic/adaptive-fixes branch May 2, 2020 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevengum stevengum stevengum approved these changes

@chon219 chon219 Awaiting requested review from chon219

@benbrown benbrown Awaiting requested review from benbrown

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Stevenic @coveralls @stevengum