Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stevenic/update master #2214

Merged
merged 11 commits into from May 8, 2020
Merged

Stevenic/update master #2214

merged 11 commits into from May 8, 2020

Conversation

Stevenic
Copy link
Contributor

@Stevenic Stevenic commented May 8, 2020

Fixes #2213

Merge changes from 4.9 branch into master

garypretty and others added 8 commits May 5, 2020 14:17
* Update app insights package version

* Add PageView logging

* move TelemetryView helper to botTelemetryClient.ts

* remove telemetry Extensions class, harden helper method, add tests

Co-authored-by: Steven Gum <14935595+stevengum@users.noreply.github.com>
* move botbuilder-lg and adaptive-expressions out of preview

* correct set-version script in preview packages

* restore preview packages to using Version instead of PreviewPackageVersion
* [PORT] [Expression] Add more timex builtin functions (#2187)

* add more timex function

* fix typo

* fix typo

* Add formatNumber, parseEpoch and parseTicks. (#2198)

* Add formatNumber, parseEpoch and parseTicks.

* Switch to ESNext like other packages.
Switch ticks to bigInt.
Add tests.

Co-authored-by: Shuai Wang <shuwan@microsoft.com>

Co-authored-by: Hongyang Du (hond) <hond@microsoft.com>
Co-authored-by: Chris McConnell <chrimc@microsoft.com>
Co-authored-by: Shuai Wang <shuwan@microsoft.com>
* Drop back to es5 and add bigint support.

* Fix test script.

* Fix test script.

* Remove adaptive.

* Remove space.

* Remove changes to package.json.

* update adaptive-expressions target to es5 for initial testing

* Push es5.

Co-authored-by: stevengum <14935595+stevengum@users.noreply.github.com>
@Stevenic Stevenic requested a review from stevengum May 8, 2020 18:55
@coveralls
Copy link

coveralls commented May 8, 2020

Pull Request Test Coverage Report for Build 129544

  • 4 of 4 (100.0%) changed or added relevant lines in 3 files are covered.
  • 9 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.08%) to 79.998%

Files with Coverage Reduction New Missed Lines %
libraries/botframework-streaming/src/webSocket/webSocketTransport.ts 2 80.65%
libraries/botframework-streaming/src/webSocket/webSocketServer.ts 7 66.67%
Totals Coverage Status
Change from base Build 129252: -0.08%
Covered Lines: 12650
Relevant Lines: 15088

💛 - Coveralls

* Renamed BeginSkill action again

* update component registration
@Stevenic Stevenic merged commit 001ecb5 into master May 8, 2020
@Stevenic Stevenic deleted the stevenic/update-master branch May 8, 2020 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Merge 4.9 into master
6 participants