Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PORT]test comparisons for null #2276

Merged
merged 5 commits into from
May 27, 2020
Merged

[PORT]test comparisons for null #2276

merged 5 commits into from
May 27, 2020

Conversation

Danieladu
Copy link
Contributor

Fixes #2262

@coveralls
Copy link

coveralls commented May 27, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 133773

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 9 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.07%) to 80.286%
Files with Coverage Reduction New Missed Lines %
libraries/botframework-streaming/src/webSocket/webSocketTransport.ts 2 80.65%
libraries/botframework-streaming/src/webSocket/webSocketServer.ts 7 66.67%
Totals Coverage Status
Change from base Build 133764: -0.07%
Covered Lines: 12692
Relevant Lines: 15093
💛 - Coveralls

@Danieladu Danieladu merged commit 8be1b77 into master May 27, 2020
@Danieladu Danieladu deleted the hond/port branch May 27, 2020 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cosmicshuai cosmicshuai cosmicshuai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[PORT] test comparisons for null
3 participants
@Danieladu @coveralls @cosmicshuai