Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to Chrome ^83.0.0 #2279

Merged
merged 1 commit into from
May 27, 2020
Merged

Upgrade to Chrome ^83.0.0 #2279

merged 1 commit into from
May 27, 2020

Conversation

BruceHaley
Copy link
Contributor

This fixes build Run-JS-Functional-Tests-BrowserBot-yaml which has been failing.

@coveralls
Copy link

coveralls commented May 27, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 133952

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 9 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.07%) to 80.286%
Files with Coverage Reduction New Missed Lines %
libraries/botframework-streaming/src/webSocket/webSocketTransport.ts 2 80.65%
libraries/botframework-streaming/src/webSocket/webSocketServer.ts 7 66.67%
Totals Coverage Status
Change from base Build 133839: -0.07%
Covered Lines: 12692
Relevant Lines: 15093
💛 - Coveralls

@stevengum stevengum merged commit e662a0b into master May 27, 2020
@stevengum stevengum deleted the v-bruhal/chromeupd5-27 branch May 27, 2020 23:23
stevengum added a commit that referenced this pull request May 28, 2020
@stevengum
Port #2279 chromedriver fix to 4.9 branch
eb4f384
@stevengum stevengum mentioned this pull request May 28, 2020
Merged
stevengum added a commit that referenced this pull request May 28, 2020
@stevengum
Port #2279 chromedriver fix to 4.9 branch (#2282)
cad3701
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cleemullins cleemullins cleemullins approved these changes

@stevengum stevengum stevengum approved these changes

@mrivera-ms mrivera-ms Awaiting requested review from mrivera-ms

@benbrown benbrown Awaiting requested review from benbrown

@Stevenic Stevenic Awaiting requested review from Stevenic

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@BruceHaley @coveralls @cleemullins @stevengum