Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed repeat dialog options #2300

Merged
merged 3 commits into from
Jun 10, 2020
Merged

fixed repeat dialog options #2300

merged 3 commits into from
Jun 10, 2020

Conversation

chon219
Copy link
Member

@chon219 chon219 commented Jun 2, 2020

Fixes #2035

Description

Pass options into RepeatDialog

Specific Changes

  • Call parent's constructor to pass options in RepeatDialog's constructor

Testing

Added test case to cover this change.

@chon219 chon219 self-assigned this Jun 2, 2020
@coveralls
Copy link

coveralls commented Jun 2, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 137152

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 9 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.07%) to 80.84%
Files with Coverage Reduction New Missed Lines %
libraries/botframework-streaming/src/webSocket/webSocketTransport.ts 2 80.65%
libraries/botframework-streaming/src/webSocket/webSocketServer.ts 7 66.67%
Totals Coverage Status
Change from base Build 137151: -0.07%
Covered Lines: 12811
Relevant Lines: 15131
💛 - Coveralls

@stevengum stevengum merged commit bca41d9 into master Jun 10, 2020
@stevengum stevengum deleted the zim/fix-repeat-dialog-options branch June 10, 2020 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevengum stevengum stevengum approved these changes

@luhan2017 luhan2017 luhan2017 approved these changes

@Stevenic Stevenic Awaiting requested review from Stevenic

Assignees

@chon219 chon219

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[PORT] fix repeat option
4 participants
@chon219 @coveralls @stevengum @luhan2017