Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PORT]Adjust grammar to improve LG parsing performance #2303

Merged
merged 1 commit into from
Jun 4, 2020
Merged

[PORT]Adjust grammar to improve LG parsing performance #2303

merged 1 commit into from
Jun 4, 2020

Conversation

Danieladu
Copy link
Contributor

@Danieladu Danieladu commented Jun 3, 2020 •
edited
Loading

Adjust some grammar to improve the performance of LG parsing.

issue link: microsoft/botbuilder-dotnet#4006

close: #2304

@coveralls
Copy link

coveralls commented Jun 3, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 135625

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 9 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.07%) to 80.283%
Files with Coverage Reduction New Missed Lines %
libraries/botframework-streaming/src/webSocket/webSocketTransport.ts 2 80.65%
libraries/botframework-streaming/src/webSocket/webSocketServer.ts 7 66.67%
Totals Coverage Status
Change from base Build 135268: -0.07%
Covered Lines: 12699
Relevant Lines: 15102
💛 - Coveralls

@Danieladu Danieladu merged commit cb95a0a into master Jun 4, 2020
@Danieladu Danieladu deleted the hond/perf branch June 4, 2020 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cosmicshuai cosmicshuai cosmicshuai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[PORT] Adjust grammar to improve LG parsing performance
3 participants
@Danieladu @coveralls @cosmicshuai