Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set recognized properties even if interruption is off #2360

Merged
merged 4 commits into from
Jun 18, 2020
Merged

set recognized properties even if interruption is off #2360

merged 4 commits into from
Jun 18, 2020

Conversation

songcs
Copy link
Contributor

@songcs songcs commented Jun 16, 2020

Fixes #2079

Description

Set recognized properties even if interruption is off.

Specific Changes

  • change spelling to sync with .Net: recognized -> recognizedResult
  • set TurnPath.TopIntent etc.

chrimc62
chrimc62 suggested changes Jun 16, 2020
View reviewed changes
Copy link
Contributor

@chrimc62 chrimc62 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕐

@songcs songcs requested review from chrimc62 and chon219 June 17, 2020 09:19
chrimc62
chrimc62 approved these changes Jun 17, 2020
View reviewed changes
Copy link
Contributor

@chrimc62 chrimc62 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@chon219 chon219 merged commit b33d824 into microsoft:master Jun 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrimc62 chrimc62 chrimc62 approved these changes

@boydc2014 boydc2014 Awaiting requested review from boydc2014

@carlosscastro carlosscastro Awaiting requested review from carlosscastro

@luhan2017 luhan2017 Awaiting requested review from luhan2017

@stevengum stevengum Awaiting requested review from stevengum

@Stevenic Stevenic Awaiting requested review from Stevenic

@chon219 chon219 Awaiting requested review from chon219

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[PORT] set recognized properties even if interruption is off
3 participants
@songcs @chon219 @chrimc62