Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PORT]Extend 'getProperty' builtin function to support accessing top memory #2437

Merged
merged 2 commits into from
Jun 30, 2020

Conversation

Danieladu
Copy link
Contributor

@Danieladu Danieladu commented Jun 28, 2020

issue link: microsoft/botbuilder-dotnet#4029
Fixes #2448

Originally, getProperty accepts two parameters, the first parameter is an instance, and the second parameter is the property name which user wants to access the value from. In this mode, the user can not access the top-level memory from dynamic/special string property.

After this change, getProperty accepts only one parameter, that presents the root property from the memory.

Example:
Scope is :

{
"a:b": "value"
}

getProperty('a:b') would get string "value",

@coveralls
Copy link

coveralls commented Jun 28, 2020

Pull Request Test Coverage Report for Build 142036

  • 9 of 9 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.006%) to 81.026%

Totals Coverage Status
Change from base Build 142026: 0.006%
Covered Lines: 12965
Relevant Lines: 15283

💛 - Coveralls

Copy link
Contributor

@chrimc62 chrimc62 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@Danieladu Danieladu merged commit 18a2191 into master Jun 30, 2020
@Danieladu Danieladu deleted the hond/getProperty branch June 30, 2020 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[PORT] Extend 'getProperty' builtin function to support accessing top memory.
3 participants