Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move TelemetryClient property to DialogContainer #2463

Merged
merged 1 commit into from
Jul 1, 2020

Conversation

mrestorff
Copy link
Contributor

Fixes #2454

Description

Move TelemetryClient onto DialogContainer (implementation the same in AdaptiveDialog and ComponentDialog).

Specific Changes

  • Move TelemetryClient onto DialogContainer
  • remove TelemetryClient from AdaptiveDialog and ComponentDialog

Testing

N/A

Copy link
Member

@stevengum stevengum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this! :shipit:

@stevengum stevengum merged commit c4488ce into microsoft:master Jul 1, 2020
@mrestorff mrestorff deleted the moveTelemetryClient branch July 2, 2020 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[PORT] Move TelemetryClient property to DialogContainer
2 participants