-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Teams' Channel Restored event #2470
Add Teams' Channel Restored event #2470
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix the return docstrings: task
is the not the appropriate value
* @returns A task that represents the work queued to execute.
@stevengum Thanks for the feedback, we just applied it and fix the master merge conflicts. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small comment for the new test
@stevengum We updated the code. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Fixes #2367
Description
This PR adds the Teams' Channel Restored event in teamsActivityHandler class.
Specific Changes
Testing
The following image shows the new event being handled by a test bot.
![image](https://user-images.githubusercontent.com/44245136/86260713-044e0f80-bb94-11ea-9067-cee8e2df5be3.png)
The next image shows the new test passing.
![image](https://user-images.githubusercontent.com/44245136/86260740-0adc8700-bb94-11ea-9544-110c3332edc1.png)