Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Teams' Channel Restored event #2470

Merged

Conversation

denscollo
Copy link
Contributor

Fixes #2367

Description

This PR adds the Teams' Channel Restored event in teamsActivityHandler class.

Specific Changes

Testing

The following image shows the new event being handled by a test bot.
image

The next image shows the new test passing.
image

@denscollo denscollo requested a review from a team as a code owner July 1, 2020 20:32
Copy link
Member

@stevengum stevengum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the return docstrings: task is the not the appropriate value

* @returns A task that represents the work queued to execute.

@denscollo denscollo requested a review from a team as a code owner July 14, 2020 19:52
@denscollo
Copy link
Contributor Author

@stevengum Thanks for the feedback, we just applied it and fix the master merge conflicts.

Copy link
Member

@stevengum stevengum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small comment for the new test

libraries/botbuilder/tests/teamsActivityHandler.test.js Outdated Show resolved Hide resolved
@denscollo
Copy link
Contributor Author

@stevengum We updated the code. Thanks!

Copy link
Member

@stevengum stevengum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! :shipit:

@stevengum stevengum merged commit 5aa5159 into microsoft:master Jul 21, 2020
@ceciliaavila ceciliaavila deleted the southworks/add/channel-restored-event branch August 17, 2023 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Additional channel/chat lifecycle events (JS)
3 participants