Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add directlinespeech support to prompts #2479

Merged
merged 4 commits into from
Jul 6, 2020
Merged

Conversation

stevengum
Copy link
Member

Fixes in JS: microsoft/botframework-sdk#5950

Description

Adds directlinespeech to channel.ts which determines the suggestedAction and cardAction support in the prompts.

The buttonCount limits follow Web Chat and Directline because this is in the context of Direct Line Speech via Web Chat.

Specific Changes

  • Adds directlinespeech to channel.ts helper functions
  • Add tests for channel.ts changes
  • Regenerate botbuilder-dialogs.api.md

Testing

Unit tests and manually tested via 06.using-cards & 03.speech/a.direct-line-speech on chromium edge.

FYI @varunbmallik, @compulim, @NickEricson, @dmvtech

@stevengum stevengum requested a review from a team as a code owner July 3, 2020 01:24
@coveralls
Copy link

coveralls commented Jul 3, 2020

Pull Request Test Coverage Report for Build 143669

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 9 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.07%) to 80.964%

Files with Coverage Reduction New Missed Lines %
libraries/botframework-streaming/src/webSocket/webSocketTransport.ts 2 80.65%
libraries/botframework-streaming/src/webSocket/webSocketServer.ts 7 66.67%
Totals Coverage Status
Change from base Build 143420: -0.07%
Covered Lines: 12973
Relevant Lines: 15305

💛 - Coveralls

@stevengum stevengum merged commit e29d229 into master Jul 6, 2020
@stevengum stevengum deleted the stgum/dls/prompts branch July 6, 2020 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants