Increase code coverage in botbuilder library - ChannelServiceRoutes class #2540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…se-code-coverage/channelServiceRoutes
|
This branch is out of date. Please rebase from master (cannot do this automatically from github, because the PR is from a fork) |
EricDahlvang
suggested changes
Jul 16, 2020
|
@EricDahlvang We just applied the feedback and update it with the master branch, so it's ready. Thanks! |
stevengum
reviewed
Jul 17, 2020
|
@stevengum We just pushed the feedback. Thanks! |
stevengum
approved these changes
Jul 28, 2020
EricDahlvang
approved these changes
Jul 29, 2020
denscollo
deleted the
southworks/increase-code-coverage/channelServiceRoutes
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #2432
Description
This PR adds the
channelServiceRoutes.test.jswith unit tests for the ChannelServiceRoutes class, increasing code coverage for the class to 88,97%.Testing