Increase code coverage in botbuilder library - InspectionMiddleware class #2541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denscollo
requested review from
carlosscastro,
johnataylor,
stevengum and
Stevenic
as code owners
EricDahlvang
previously requested changes
Jul 16, 2020
|
Awesome increase in coverage! ty! |
|
@EricDahlvang We just finished applying the feedback. Thanks! |
|
@stevengum We just pushed the changes. Thanks! |
stevengum
approved these changes
Jul 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #2432
Description
This PR adds unit tests for the InspectionMiddleware class, these tests were added in the inspectionMiddleware.test.js file, increasing code coverage from 81% to 99%.
Testing
In the images below are new tests and the total class coverage.
