Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Engineering] Cleanup dependencies/use same dep version where possible #2545

Merged

Conversation

denscollo
Copy link
Contributor

Fixes #1333

Description

This PR updates all the packages dependencies to maintain parity between the packages that are using them, this update removes all the warning logs (EHOIST_ROOT_VERSION and EHOIST_PKG_VERSION) that were showing up when running lerna bootstrap --hoist command.

Specific Changes

Dependencies change log

Dependency Before After
@types/jsonwebtoken ^8.3.2 7.2.8
@types/mocha ^2.2.47 ^5.2.7
@types/moment-timezone ^0.5.12 ^0.5.13
@types/node ^10.12.18 ^10.17.27
@types/node-fetch ^2.3.2 ^2.5.7
applicationinsights 1.7.5 ^1.7.5
dotenv ^5.0.1 ^6.2.0
fs-extra ^7.0.0 ^7.0.1
mocha ^5.2.0 ^6.2.3
node-fetch ^2.3.0 ^2.6.0
nyc ^11.4.1" ^15.1.0
restify ^8.3.0 ^8.5.1
sinon ^7.4.1 ^7.5.0
uuid ^3.3.2 ^3.4.0

@types/jsonwebtoken

  • root version ^8.3.2
  • botframework-connector version 7.2.8

Note: @types/jsonwebtoken has been downgraded from ^8.3.2 to 7.2.8 since it is only used in the botframework-connector package, the reason is that botframework-connector has the jsonwebtoken dependency with a version of 8.0.1, upgrading @types/jsonwebtoken for it from 7.2.8 to ^8.3.2 will cause the package to fail in the build process for unsupported types.

Testing

In the following images are the lerna bootstrap --hoist command showing without the warnings and the build script running successfully.
image
image

@denscollo denscollo requested review from stevengum and a team as code owners July 17, 2020 19:00
@stevengum stevengum merged commit 1adbce6 into microsoft:master Jul 22, 2020
@ceciliaavila ceciliaavila deleted the southworks/update/dependencies-warnings branch July 22, 2020 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Engineering] Cleanup dependencies/use same dep version where possible
4 participants