Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Engineering] Lower time for botbuilder-azure tests #2629

Conversation

denscollo
Copy link
Contributor

Addresses #2338

Description

Updates the warnings raised in some tests of the BotBuilder-Azure library to be shown once for the describe instead of each test inside it.

Specific Changes

Update the tests in the files blobStorage.test.js and cosmosDbStorage.test.js to run the emulator check once in the describes to raise a warning instead of running it in each test of the describe. This change reduces the time for the tests a little bit and makes the test report more readable.

We also updated some eslint warnings in these files.

Testing

Here you can compare the times for each test running when moving the warning to be shown once for the describe and how it is more readable in the report.
image
image
image

Note: the times vary in each run, but in general there is a slight reduction in the times.

Copy link
Member

@EricDahlvang EricDahlvang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mrivera-ms mrivera-ms merged commit 6172deb into microsoft:master Aug 6, 2020
@denscollo denscollo deleted the southworks/update/botbuilder-azure-tests branch August 6, 2020 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants