Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a LG bug with a corner case in multiline scenario #3004

Merged
merged 3 commits into from
Nov 9, 2020

Conversation

Danieladu
Copy link
Contributor

Issue link: microsoft/BotFramework-Composer#4262

Description

Originally, LG would break for the below case:

# template
- ```

The cause is that LG does not allow empty multiline-text in multiline area before.
Make the multiline-text could be empty to fix this issue.

Specific Changes

  • Change the parser file of LG to allow the empty multiline text
  • Add a test to verify this change

@Danieladu Danieladu requested a review from a team as a code owner November 5, 2020 13:40
@joshgummersall joshgummersall merged commit 3589eff into main Nov 9, 2020
@joshgummersall joshgummersall deleted the hond/fix-multiline branch November 9, 2020 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants