Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Azure queues and ContinueConversationLater/OnContinueConversation #3083

Merged
merged 22 commits into from
Dec 22, 2020
Merged

Azure queues and ContinueConversationLater/OnContinueConversation #3083

merged 22 commits into from
Dec 22, 2020

Conversation

chon219
Copy link
Member

@chon219 chon219 commented Nov 23, 2020

Fixes #2393

Description

Azure queues and ContinueConversationLater/OnContinueConversation

Specific Changes

  • New package botbuilder-azure-queues
  • QueueStorage in botbuilder-core
  • New action: ContinueConversationLater
  • New trigger: OnContinueConversation

Testing

@coveralls
Copy link

coveralls commented Nov 23, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 437591561

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 6 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.2%) to 84.257%
Files with Coverage Reduction New Missed Lines %
libraries/adaptive-expressions/src/triggerTrees/node.ts 2 95.26%
libraries/adaptive-expressions/src/triggerTrees/trigger.ts 4 61.05%
Totals Coverage Status
Change from base Build 437320452: -0.2%
Covered Lines: 17672
Relevant Lines: 20036
💛 - Coveralls

joshgummersall
joshgummersall suggested changes Nov 23, 2020
View reviewed changes
Copy link
Contributor

@joshgummersall joshgummersall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I have a few small comments, otherwise, it looks good.

libraries/botbuilder-azure-queues/src/azureQueueStorage.ts Outdated Show resolved Hide resolved
libraries/botbuilder-dialogs-adaptive/src/actions/continueConversationLater.ts Outdated Show resolved Hide resolved
libraries/botbuilder-dialogs-adaptive/src/actions/continueConversationLater.ts Outdated Show resolved Hide resolved
libraries/botbuilder-dialogs-adaptive/src/actions/continueConversationLater.ts Outdated Show resolved Hide resolved
libraries/botbuilder-dialogs-adaptive/src/actions/continueConversationLater.ts Outdated Show resolved Hide resolved
@chon219 chon219 marked this pull request as ready for review November 25, 2020 10:40
@chon219 chon219 requested a review from a team as a code owner December 22, 2020 08:14
@joshgummersall joshgummersall merged commit 9c0850d into main Dec 22, 2020
@joshgummersall joshgummersall deleted the zim/azure-queues branch December 22, 2020 15:24
This was referenced Dec 30, 2020
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshgummersall joshgummersall joshgummersall approved these changes

@carlosscastro carlosscastro Awaiting requested review from carlosscastro

@johnataylor johnataylor Awaiting requested review from johnataylor

@stevengum stevengum Awaiting requested review from stevengum

@Stevenic Stevenic Awaiting requested review from Stevenic

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[PORT] Add OnContinueConversation trigger and ContinueConversationLater action
3 participants
@chon219 @coveralls @joshgummersall