Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: adaptive dialog functions #3250

Merged
merged 6 commits into from
Feb 8, 2021
Merged

feat: adaptive dialog functions #3250

merged 6 commits into from
Feb 8, 2021

Conversation

chon219
Copy link
Member

@chon219 chon219 commented Feb 1, 2021

Fixes #3238

Description

Ported adaptive functions in botbuilder-dialogs-adaptive

Specific Changes

  • Added function hasPendingActions
  • Added function isDialogActive
  • Registered functions in AdaptiveComponentRegistration

Testing

Ported tests for adaptive dialog functions

@chon219 chon219 added Area: Adaptive The issue is related to Adaptive dialogs Area: Adaptive expression The issue is related to Adaptive expressions labels Feb 1, 2021
@chon219 chon219 added this to the R12 milestone Feb 1, 2021
@chon219 chon219 requested review from a team as code owners February 1, 2021 09:40
@chon219 chon219 requested a review from Stevenic February 1, 2021 09:40
@coveralls
Copy link

coveralls commented Feb 1, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 546596348

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.007%) to 84.894%
Totals Coverage Status
Change from base Build 545924660: -0.007%
Covered Lines: 18284
Relevant Lines: 20558
💛 - Coveralls

joshgummersall
joshgummersall suggested changes Feb 2, 2021
View reviewed changes
Copy link
Contributor

@joshgummersall joshgummersall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small fix and a suggestion for future work, otherwise looks good.

libraries/botbuilder-dialogs-adaptive-testing/tests/functions.test.js Show resolved Hide resolved
libraries/botbuilder-dialogs-adaptive/src/functions/isDialogActiveFunction.ts Outdated Show resolved Hide resolved
@chon219 chon219 merged commit bc2bda0 into main Feb 8, 2021
@chon219 chon219 deleted the zim/adaptive-dialog-functions branch February 8, 2021 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshgummersall joshgummersall joshgummersall approved these changes

@Stevenic Stevenic Awaiting requested review from Stevenic

Assignees
No one assigned
Labels
Area: Adaptive expression The issue is related to Adaptive expressions Area: Adaptive The issue is related to Adaptive dialogs
Projects
None yet
Milestone
R12
Development

Successfully merging this pull request may close these issues.

[PORT] Adaptive dialog functions
3 participants
@chon219 @coveralls @joshgummersall