Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: support null memory values #3290

Merged
merged 3 commits into from
Feb 10, 2021
Merged

fix: support null memory values #3290

merged 3 commits into from
Feb 10, 2021

Conversation

joshgummersall
Copy link
Contributor

Fixes #3265

@Danieladu the change was a bit different as the !== null check was located in a different place. Does this change seem reasonable?

@joshgummersall joshgummersall requested review from a team as code owners February 9, 2021 18:46
@coveralls
Copy link

coveralls commented Feb 9, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 553322593

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 3 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.02%) to 84.869%
Files with Coverage Reduction New Missed Lines %
libraries/botbuilder-lg/src/templateExtensions.ts 1 84.48%
libraries/adaptive-expressions/src/triggerTrees/trigger.ts 2 61.63%
Totals Coverage Status
Change from base Build 553320355: -0.02%
Covered Lines: 18554
Relevant Lines: 20846
💛 - Coveralls

stevengum
stevengum approved these changes Feb 9, 2021
View reviewed changes
Copy link
Member

@stevengum stevengum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@stevengum stevengum merged commit 3132e02 into main Feb 10, 2021
@stevengum stevengum deleted the jpg/fix-null-memory-value branch February 10, 2021 02:56
@Danieladu
Copy link
Contributor

That make sense.
Treat undefined as "not found", and treat null as a valid value.
Thanks, Josh, for your porting!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevengum stevengum stevengum approved these changes

@Stevenic Stevenic Awaiting requested review from Stevenic

@tomlm tomlm Awaiting requested review from tomlm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

port: [Expression] Support return null result in stack memory
4 participants
@joshgummersall @coveralls @Danieladu @stevengum