Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add eslint-plugin-import #3293

Merged
merged 3 commits into from
Feb 10, 2021
Merged

fix: add eslint-plugin-import #3293

merged 3 commits into from
Feb 10, 2021

Conversation

joshgummersall
Copy link
Contributor

@joshgummersall joshgummersall commented Feb 9, 2021 •
edited
Loading

Ensures we have dependencies listed properly.

EDIT: I reorganized the root eslint config a bit to make the order a bit more natural.

@joshgummersall joshgummersall requested review from stevengum and a team as code owners February 9, 2021 21:57
stevengum
stevengum approved these changes Feb 9, 2021
View reviewed changes
Copy link
Member

@stevengum stevengum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small thing about the new dependencies, otherwise the entire PR LGTM

libraries/botbuilder-dialogs-adaptive-teams/package.json Outdated Show resolved Hide resolved
@joshgummersall joshgummersall requested a review from a team as a code owner February 9, 2021 22:45
@coveralls
Copy link

coveralls commented Feb 9, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 552935555

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 10 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.04%) to 84.841%
Files with Coverage Reduction New Missed Lines %
libraries/adaptive-expressions/src/triggerTrees/trigger.ts 2 62.79%
libraries/adaptive-expressions/src/triggerTrees/node.ts 8 91.7%
Totals Coverage Status
Change from base Build 552749743: -0.04%
Covered Lines: 18548
Relevant Lines: 20846
💛 - Coveralls

@stevengum stevengum merged commit 2132f90 into main Feb 10, 2021
@stevengum stevengum deleted the jpg/eslint-plugin-import branch February 10, 2021 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevengum stevengum stevengum approved these changes

@Stevenic Stevenic Awaiting requested review from Stevenic

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@joshgummersall @coveralls @stevengum