Enable Orchestrator entity recognition when entity model is provided #3441

tsuwandy · 2021-03-25T07:13:55Z

Fixes #
#3440

Description

Detect entity model folder inside model folder when model is initialized and set entity scoring flag to true
Call LabelResolver.Score for entity
Add results to recognizerResult.Entities collection

This PR also contains Orchestrator telemetry updates from @daveta

…crosoft/botbuilder-js into tiens-orchestrator-recognizer

libraries/botbuilder-ai-orchestrator/tests/orchestratorAdaptiveRecognizer.test.js

libraries/botbuilder-ai-orchestrator/tests/mockResolver.js

libraries/botbuilder-ai-orchestrator/tests/recognizerTelemetryUtils.js

package.json

libraries/botbuilder-ai-orchestrator/src/orchestratorAdaptiveRecognizer.ts

…crosoft/botbuilder-js into tiens-orchestrator-recognizer

libraries/botbuilder-ai-orchestrator/src/orchestratorAdaptiveRecognizer.ts

coveralls · 2021-03-25T18:21:26Z

Pull Request Test Coverage Report for Build 690943451

0 of 0 changed or added relevant lines in 0 files are covered.
32 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.002%) to 85.002%

Files with Coverage Reduction	New Missed Lines	%
libraries/botbuilder-ai-orchestrator/src/orchestratorAdaptiveRecognizer.ts	32	68.4%

Totals
Change from base Build 690889150:	-0.002%
Covered Lines:	18912
Relevant Lines:	21180

💛 - Coveralls

libraries/botbuilder-ai-orchestrator/src/orchestratorAdaptiveRecognizer.ts

congysu

Thanks.

…ater

libraries/botbuilder-ai-orchestrator/package.json

joshgummersall

One quick question.

tsuwandy and others added 7 commits March 23, 2021 10:34

Removed orchestratorRecognizer

d4b2446

check entity model folder and load orchestrator with entity model

57ade54

Add telemetry updates

67110fc

Merge branch 'tiens-orchestrator-recognizer' of https://github.com/mi…

665fc64

…crosoft/botbuilder-js into tiens-orchestrator-recognizer

Merge branch 'main' into tiens-orchestrator-recognizer

16d9700

Update orchestratorAdaptiveRecognizer.ts

413aa89

added entity test

0564524

tsuwandy requested review from chrimc62, joshgummersall, stevengum, tomlm and a team as code owners March 25, 2021 07:13

tsuwandy requested review from daveta and hcyang March 25, 2021 07:14

joshgummersall suggested changes Mar 25, 2021

View reviewed changes

daveta and others added 4 commits March 25, 2021 10:36

Updates for CR feedback

26cb176

addressed review comments, fixed some issues from yarn lint

44fef57

Merge branch 'tiens-orchestrator-recognizer' of https://github.com/mi…

e2cbae9

…crosoft/botbuilder-js into tiens-orchestrator-recognizer

fixed tests

a44aee7

joshgummersall reviewed Mar 25, 2021

View reviewed changes

libraries/botbuilder-ai-orchestrator/src/orchestratorAdaptiveRecognizer.ts Outdated Show resolved Hide resolved

libraries/botbuilder-ai-orchestrator/src/orchestratorAdaptiveRecognizer.ts Outdated Show resolved Hide resolved

tsuwandy and others added 4 commits March 25, 2021 11:06

yarn lint fixes

038dfe3

addressed more PR comments

bd50f33

Updates

c1f1297

Remove lodash/omit

1c74d5a

daveta added 3 commits March 25, 2021 11:44

Lint issues

17382f7

Add comment for omit

c4f1516

Fix test:orchestator command

5567d31

daveta requested a review from congysu March 25, 2021 22:00

congysu reviewed Mar 25, 2021

View reviewed changes

libraries/botbuilder-ai-orchestrator/src/orchestratorAdaptiveRecognizer.ts Outdated Show resolved Hide resolved

congysu approved these changes Mar 25, 2021

View reviewed changes

daveta and others added 3 commits March 25, 2021 15:31

Update package to latest R13. We'll update to rc and full R13 build l…

925732d

…ater

Merge branch 'main' into tiens-orchestrator-recognizer

ec65bd1

updated per PR comments, added tests

7b2da8e

hcyang approved these changes Mar 26, 2021

View reviewed changes

tsuwandy and others added 3 commits March 26, 2021 10:47

Merge branch 'main' into tiens-orchestrator-recognizer

395066c

Merge branch 'main' into tiens-orchestrator-recognizer

2a78304

updated schema

678f192

joshgummersall reviewed Mar 26, 2021

View reviewed changes

libraries/botbuilder-ai-orchestrator/package.json Show resolved Hide resolved

joshgummersall reviewed Mar 26, 2021

View reviewed changes

joshgummersall approved these changes Mar 26, 2021

View reviewed changes

joshgummersall merged commit 5bb86c4 into main Mar 26, 2021

joshgummersall deleted the tiens-orchestrator-recognizer branch March 26, 2021 19:42

joshgummersall mentioned this pull request Mar 30, 2021

Enable Orchestrator named entity recognition when entity base model is provided inside intent model folder #3440

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Enable Orchestrator entity recognition when entity model is provided #3441

Enable Orchestrator entity recognition when entity model is provided #3441

tsuwandy commented Mar 25, 2021 •

edited

coveralls commented Mar 25, 2021 •

edited

congysu left a comment

joshgummersall left a comment

Enable Orchestrator entity recognition when entity model is provided #3441

Enable Orchestrator entity recognition when entity model is provided #3441

Conversation

tsuwandy commented Mar 25, 2021 • edited

Description

coveralls commented Mar 25, 2021 • edited

Pull Request Test Coverage Report for Build 690943451

💛 - Coveralls

congysu left a comment

Choose a reason for hiding this comment

joshgummersall left a comment

Choose a reason for hiding this comment

tsuwandy commented Mar 25, 2021 •

edited

coveralls commented Mar 25, 2021 •

edited