Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [#4466] Fix telemetry activityId and conversationId properties #4471

Merged
merged 2 commits into from
May 5, 2023

Conversation

sw-joelmut
Copy link
Collaborator

Fixes #4466

Description

This PR adds the activityId and conversationId properties to the TelemetryLoggerMiddleware functionality. Additionally, it fixes a port issue where the activity.id property wasn't being available after sending the activities.

Specific Changes

  • Added activityId key property to the telemetry constants class.
  • Added activityId property to the TelemetryLoggerMiddleware class.
  • Fixed a port issue where the activity.id property wasn't available after sending the activities.
  • Updated unit tests to assert over the conversationId and activityId properties.

Testing

The following image shows how the activityId and conversationId properties are displayed correctly.
image

@sw-joelmut sw-joelmut requested a review from a team as a code owner May 3, 2023 12:49
@coveralls
Copy link

coveralls commented May 3, 2023

Pull Request Test Coverage Report for Build 4872067562

  • 8 of 8 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.4%) to 84.73%

Totals Coverage Status
Change from base Build 4792156003: 0.4%
Covered Lines: 20043
Relevant Lines: 22417

💛 - Coveralls

@tracyboehrer tracyboehrer merged commit c3c1bf1 into main May 5, 2023
@tracyboehrer tracyboehrer deleted the southworks/fix/telemetry-activityId branch May 5, 2023 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

port: [#6616] Telemetry not logging ActivityID and ConversationID
3 participants