Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

port: [#4464] USER scope variable values do not transfer to skill when SSO is configured #4472

Merged
merged 2 commits into from
May 5, 2023

Conversation

ceciliaavila
Copy link
Collaborator

Fixes #4464

Description

This PR ports the changes from PR#6612 to save the state after setting the properties avoiding user scope properties to lose their value.

Specific Changes

Testing

These images show the user scope variable before and after the fix.
image

@ceciliaavila ceciliaavila requested a review from a team as a code owner May 4, 2023 14:28
@coveralls
Copy link

coveralls commented May 4, 2023

Pull Request Test Coverage Report for Build 4884012016

  • 2 of 2 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.4%) to 84.73%

Totals Coverage Status
Change from base Build 4875858664: 0.4%
Covered Lines: 20037
Relevant Lines: 22411

💛 - Coveralls

@tracyboehrer tracyboehrer merged commit dba563d into main May 5, 2023
15 checks passed
@tracyboehrer tracyboehrer deleted the southworks/update/set-property-save-state branch May 5, 2023 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

port: USER scope variable values do not transfer to skill when SSO is configured
3 participants