Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Updates fast-xml-parser to address "Prototype Pollution" vulnerability #4477

Merged
merged 2 commits into from
May 30, 2023
Merged

fix: Updates fast-xml-parser to address "Prototype Pollution" vulnerability #4477

merged 2 commits into from
May 30, 2023

Conversation

giacomorebonato
Copy link
Contributor

@giacomorebonato giacomorebonato commented May 15, 2023 •
edited by ceciliaavila
Loading

https://security.snyk.io/vuln/SNYK-JS-FASTXMLPARSER-3325616

#minor

Description

Specific Changes

Testing

@giacomorebonato giacomorebonato requested a review from a team as a code owner May 15, 2023 14:48
ceciliaavila
ceciliaavila requested changes May 16, 2023
View reviewed changes
Copy link
Collaborator

@ceciliaavila ceciliaavila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @giacomorebonato, please check the unit tests, there's one failing in expressionParser.test. Also, you should include the updated yaml.lock file.

@giacomorebonato
Copy link
Contributor Author

j2xParser was renamed in fast-xml-parser. I updated the code.

@giacomorebonato
Copy link
Contributor Author

@microsoft-github-policy-service agree

@coveralls
Copy link

coveralls commented May 22, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 5031061892

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.4%) to 84.862%
Totals Coverage Status
Change from base Build 4916290236: 0.4%
Covered Lines: 20100
Relevant Lines: 22456
💛 - Coveralls

@ceciliaavila ceciliaavila changed the title Updates fast-xml-parser to address "Prototype Pollution" vulnerability fix: Updates fast-xml-parser to address "Prototype Pollution" vulnerability May 22, 2023
@giacomorebonato
Copy link
Contributor Author

Do you have any updates on this? Many thanks!

@tracyboehrer tracyboehrer merged commit 1b967e3 into microsoft:main May 30, 2023
14 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tracyboehrer tracyboehrer tracyboehrer approved these changes

@ceciliaavila ceciliaavila ceciliaavila approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@giacomorebonato @coveralls @tracyboehrer @ceciliaavila