Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [#4503] azure-storage deprecation #4510

Merged
merged 4 commits into from
Jul 28, 2023

Conversation

ceciliaavila
Copy link
Collaborator

Fixes #4503

Description

This PR migrates the botbuilder-azure library from the deprecated package azure/storage to azure/storage-blob.

Specific Changes

  • Updated azureBlobTranscriptStore and blobStorage to use the classes and functions from the new azure/storage-blob package.
  • Updated the unit tests and nock recording files in the TestData folder.
  • Removed TestData/expectedCalls file as it was no longer used.
  • Fixed how the botbuilder-azure-blobs/blobsTranscriptStore class was retrieving the transcripts when there was more than one page of results.

Testing

These images show the unit tests passing after the changes.
image

@ceciliaavila ceciliaavila requested a review from a team as a code owner July 28, 2023 13:39
@coveralls
Copy link

coveralls commented Jul 28, 2023

Pull Request Test Coverage Report for Build 5692622912

  • 95 of 115 (82.61%) changed or added relevant lines in 3 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.007%) to 84.86%

Changes Missing Coverage Covered Lines Changed/Added Lines %
libraries/botbuilder-azure/src/azureBlobTranscriptStore.ts 67 68 98.53%
libraries/botbuilder-azure/src/blobStorage.ts 28 30 93.33%
libraries/botbuilder-azure-blobs/src/blobsTranscriptStore.ts 0 17 0.0%
Files with Coverage Reduction New Missed Lines %
libraries/botbuilder-azure-blobs/src/blobsTranscriptStore.ts 2 10.05%
Totals Coverage Status
Change from base Build 5623629564: -0.007%
Covered Lines: 20135
Relevant Lines: 22485

💛 - Coveralls

@tracyboehrer tracyboehrer merged commit 51016a6 into main Jul 28, 2023
13 checks passed
@tracyboehrer tracyboehrer deleted the southworks/update/migrate-azure-storage branch July 28, 2023 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

azure-storage deprecation
3 participants