fix: [#4509] botbuilder-ai@4.20.0 is still installing @azure/ms-rest-js@1.11.2 for @azure/cognitiveservices-luis-runtime #4519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 5906567065
💛 - Coveralls |
tracyboehrer
approved these changes
Aug 18, 2023
|
@ceciliaavila Visibility for conflicts |
tracyboehrer
approved these changes
Aug 18, 2023
Hi @tracyboehrer, conflicts solved. Thanks! |
tracyboehrer
deleted the
southworks/update/azure-cognitiveservices-luis-runtime
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4509
Description
This PR upgrades
@azure/cognitiveservices-luis-runtimeto v.4.0.0 inbotbuilder-aito avoid the use of the tough-cookie package due to its vulnerability issue.As version 4.0.0 introduced several breaking changes, we added the
luisV2-modelsfolder with the interfaces and classes that are required for the v2 runtime to work.Specific Changes
@azure/cognitiveservices-luis-runtimepackage from version 2.0.0 to version 4.0.0luisV2-modelscontaining the following interfaces and classes missing in the new version of the package:luisSdk.test.jsunit tests to work with the newLUISRuntimeClientV2.Testing
This image shows the unit tests passing after the upgrade.
